Skip to content

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Mar 2, 2025

I only just noticed that these paths were silently broken by the renaming of build to builder in #134365.

This is possibly OK to just self-approve, but I would prefer to get a second set of eyes on it just in case.

@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@Zalathar
Copy link
Contributor Author

Zalathar commented Mar 2, 2025

@bors rollup=always

@jieyouxu
Copy link
Member

jieyouxu commented Mar 2, 2025

Is fine, thanks.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 2, 2025

📌 Commit 6079827 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2025
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#137375 (Minor internal comments fix for `BufRead::read_line`)
 - rust-lang#137641 (More precisely document `Global::deallocate()`'s safety.)
 - rust-lang#137755 (doc: update Wasmtime flags)
 - rust-lang#137851 (improve `simd_select` error message when used with invalid mask type)
 - rust-lang#137860 (rustc_target: Add msync target feature and enable it on powerpcspe targets)
 - rust-lang#137871 (fix `RangeBounds::is_empty` documentation)
 - rust-lang#137873 (Disable `f16` on Aarch64 without `neon`)
 - rust-lang#137876 (Adjust triagebot.toml entries for `rustc_mir_build/src/builder/`)
 - rust-lang#137883 (edit mailmap)
 - rust-lang#137886 (`name()` and `trimmed_name()` for `stable_mir::crate_def::DefId`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d031bb3 into rust-lang:master Mar 3, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 3, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2025
Rollup merge of rust-lang#137876 - Zalathar:triagebot-matches, r=jieyouxu

Adjust triagebot.toml entries for `rustc_mir_build/src/builder/`

I only just noticed that these paths were silently broken by the renaming of `build` to `builder` in rust-lang#134365.

This is *possibly* OK to just self-approve, but I would prefer to get a second set of eyes on it just in case.
@Zalathar Zalathar deleted the triagebot-matches branch March 3, 2025 07:08
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 9, 2025
tidy: add triagebot checks

Validates triagebot.toml to have existing paths:

`[mentions."*"]` sections, i.e.
```toml
[mentions."compiler/rustc_const_eval/src/"]
```
or
```toml
[assign.owners]
"/.github/workflows" = ["infra-ci"]
```
or

```toml
trigger_files = [
 "src/librustdoc/html/static/js/search.js",
 "tests/rustdoc-js",
 "tests/rustdoc-js-std",
 ]
```
Looked at rust-lang#137876 and implemented check.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 9, 2025
tidy: add triagebot checks

Validates triagebot.toml to have existing paths:

`[mentions."*"]` sections, i.e.
```toml
[mentions."compiler/rustc_const_eval/src/"]
```
or
```toml
[assign.owners]
"/.github/workflows" = ["infra-ci"]
```
or

```toml
trigger_files = [
 "src/librustdoc/html/static/js/search.js",
 "tests/rustdoc-js",
 "tests/rustdoc-js-std",
 ]
```
Looked at rust-lang#137876 and implemented check.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2025
Rollup merge of rust-lang#137885 - klensy:tidy-triagebot, r=jieyouxu

tidy: add triagebot checks

Validates triagebot.toml to have existing paths:

`[mentions."*"]` sections, i.e.
```toml
[mentions."compiler/rustc_const_eval/src/"]
```
or
```toml
[assign.owners]
"/.github/workflows" = ["infra-ci"]
```
or

```toml
trigger_files = [
 "src/librustdoc/html/static/js/search.js",
 "tests/rustdoc-js",
 "tests/rustdoc-js-std",
 ]
```
Looked at rust-lang#137876 and implemented check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants